refactor: ban-ts-ignore converter to ban-ts-comment #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingDarBoja
added
the
area: incorrect converter
JoshuaKGoldberg
approved these changes
Jun 20, 2020
There was a problem hiding this comment.
Super, thanks! This is just blocked on the 3.0.0 release right?
Edit: or, that was released - I'm down to release this now if you are @KingDarBoja? Any other blockers?
|
@JoshuaKGoldberg Actually, the PR title is wrong, it should take into account all rule removals on a single PR, that's why this is a draft and the branch name is called "ts-eslint-v3-converters". I have to do the other ones as well or do you wish to merge them in separate PRs? |
|
Oh I've definitely learned the hard way to do separate PRs. Let's get each individual one in sooner so it's easier to review them. 🚀 |
JoshuaKGoldberg
added
the
status: waiting for author
|
@JoshuaKGoldberg fair enough, feel free to merge this one 😄 I will submit the other two on separate PRs. |
JoshuaKGoldberg
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This is a draft PR to address the rule removals from typescript-eslint v3.0.0 release.